search

JLynch7 / SlickGrid

A lightning fast JavaScript grid/spreadsheet
https://github.com/jlynch7/SlickGrid/wiki
MIT License
89 stars 76 forks source link

Refactor Scrolling: scroll from any panel #43

Closed gcko closed 11 years ago

gcko commented 11 years ago

Currently while hovering over any of the frozen row or column panels, the unfrozen pane does not scroll. I changed the mousewheel event to be bound to all the panels, and factored handleScroll so that it is called from handleMousewheel.

Here is a breakdown of the functionality changes: 1) scrolling using mousewheel or trackpad works while hovering over any panel 2) maxScrollX & maxScrollY are respected on the unfrozen panel so that the header and other dependent scrolling areas don't bounce around when fast scrolling 3) handleMousewheel now calls _handleScroll 4) onMousewheel event is removed, use onScroll event instead 5) mousewheeling depends on jquery.fn.mousewheel. if it is not loaded, slickGrid falls back to default behavior (mousewheeling only works while hovering over the unfrozen panel)

gcko commented 11 years ago

@JLynch7 have you had a chance to check this out yet?

JLynch7 commented 11 years ago

Merged, with a few small tweaks. Thanks!