Changes made to handleClick() in slick.grid.js break row selection

[jusbuc2k]

The last block of handleClick() breaks row selection, because it only calls setActiveCellInternal if there are frozen rows.

I fixed this by changing this:

handleClick() {
...
  if ((activeCell != cell.cell || activeRow != cell.row) && canCellBeActive(cell.row, cell.cell)) {
                if (!getEditorLock().isActive() || getEditorLock().commitCurrentEdit()) {
                    if (hasFrozenRows) {
                        if (( !( options.frozenBottom ) && ( cell.row >= actualFrozenRow ) )
                            || ( options.frozenBottom && ( cell.row < actualFrozenRow ) )
                            ) {
                            scrollRowIntoView(cell.row, false);
                        }

                        setActiveCellInternal(getCellNode(cell.row, cell.cell));
                    }
                }
            }
}

to this:

handleClick() {
...
  if ((activeCell != cell.cell || activeRow != cell.row) && canCellBeActive(cell.row, cell.cell)) {
                if (!getEditorLock().isActive() || getEditorLock().commitCurrentEdit()) {
                    if (hasFrozenRows) {
                        if (( !( options.frozenBottom ) && ( cell.row >= actualFrozenRow ) )
                            || ( options.frozenBottom && ( cell.row < actualFrozenRow ) )
                            ) {
                            // what was the point here?
                        }
                    }
                    scrollRowIntoView(cell.row, false);
                    setActiveCellInternal(getCellNode(cell.row, cell.cell));
                }
            }
}

This eliminates any difference of handling on hasFrozenRows or not, However, I have to believe there was a reason for the conditional, but I'm not sure what it was.

Edit: Fixed codeblocks md syntax.

[gigermocas]

I had to make a similar fix on my side, as this was breaking my app regarding editor activation on click.

[Rybadour]

@jusbuc2k Assuming you want to keep his intentions you should change it to the following instead:

handleClick() {
...
  if ((activeCell != cell.cell || activeRow != cell.row) && canCellBeActive(cell.row, cell.cell)) {
                if (!getEditorLock().isActive() || getEditorLock().commitCurrentEdit()) {
                    if (hasFrozenRows) {
                        if (( !( options.frozenBottom ) && ( cell.row >= actualFrozenRow ) )
                            || ( options.frozenBottom && ( cell.row < actualFrozenRow ) )
                            ) {
                            scrollRowIntoView(cell.row, false);
                        }
                    } else {
                        scrollRowIntoView(cell.row, false);
                    }

                    setActiveCellInternal(getCellNode(cell.row, cell.cell));
                }
            }
}