search

JLyne / LiveAtlas

A Dynmap, Squaremap, Pl3xmap and Overviewer frontend for the modern web
Apache License 2.0
341 stars 37 forks source link

[Pl3xmap] Add marker updating #312

Open sudokou opened 2 years ago

sudokou commented 2 years ago

I know this is already known, and I'm not reporting it as a bug. I'm looking for a place to ask why this is the case, and if this will ever change? I searched through old Github issues, and SpigotMC discussion posts, but couldn't find anything. Hopefully this ticket can be used by people in the future looking for the same answer.

JLyne commented 2 years ago

The main reason is that, unlike Dynmap, Pl3xmap/Squaremap don't have IDs for their markers. This means LiveAtlas can't determine which markers have been updated or removed between requests, so there'd be no way of reflecting those changes without recreating all markers from scratch (which is what the stock frontend does). This would quickly become expensive when many markers exist, so I decided to ignore updates instead.

At one point it was my plan to make a PR that added IDs, but I've never found the time to do so.

sudokou commented 2 years ago

The main reason is that, unlike Dynmap, Pl3xmap/Squaremap don't have IDs for their markers. This means LiveAtlas can't determine which markers have been updated or removed between requests, so there'd be no way of reflecting those changes without recreating all markers from scratch (which is what the stock frontend does). This would quickly become expensive when many markers exist, so I decided to ignore updates instead.

At one point it was my plan to make a PR that added IDs, but I've never found the time to do so.

Would it be possible to implement an option to enable rewriting all markers, but have it disabled by default?

I have player markers that are supposed to update every 30 seconds, but with LiveAtlas obviously this is broken atm.

JLyne commented 2 years ago

Will see what I can do once I find the time 👍