JLyne / LiveAtlas

A Dynmap, Squaremap, Pl3xmap and Overviewer frontend for the modern web
Apache License 2.0
336 stars 37 forks source link

Squaremap-signs allows for injecting HTML #627

Closed CodexNotFound closed 1 year ago

CodexNotFound commented 1 year ago

Using the following sign: image

I see the following result on the map: image

This would also allow throwing an Error in the browser.

JLyne commented 1 year ago

This is an issue that needs fixing in squaremap-signs itself, as it is adding unsanitised user input into the marker tooltip and will be causing the same issue in the stock frontend.

Squaremap markers are allowed to include html in their tooltips and the official addons make frequent use of this, so it cannot be stripped out without breaking compatibility.