JMAConsulting / biz.jmaconsulting.activitytypeacl

This extension provides the ability to restrict activities on CiviCRM by roles with permissions to various activity types.
GNU Affero General Public License v3.0
4 stars 3 forks source link

CiviCRM 5.24.0 #10

Closed gibsonoliver closed 4 years ago

gibsonoliver commented 4 years ago

We have just updated a client site to Civi 5.24.0 The site uses the activity type ACL extension (with multiple Drupal roles and Case activities types per role)

Since the update the extension seems to have stopped working. The symptom we are seeing is;

Olly

JoeMurray commented 4 years ago

Olly, was this D8 or D7?

Edsel, could you look into this in the next day or two and put out a new release?

gibsonoliver commented 4 years ago

Hi Joe

It was D7

Many thanks for looking Olly

On Wed, 15 Apr 2020 at 15:19, Joe Murray notifications@github.com wrote:

Olly, was this D8 or D7?

Edsel, could you look into this in the next day or two and put out a new release?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JMAConsulting/biz.jmaconsulting.activitytypeacl/issues/10#issuecomment-614068140, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2SBYQXYCR2JYGPD6DMRLLRMW657ANCNFSM4MITHKPQ .

-- Oliver Gibson Director, Northbridge Digital Ltd

Mobile: +44(0) 7830 247789 Office: +44(0) 1457 238876 UK Company Number: 08356302 UK VAT Number: 213 8467 10 Website: www.northbridgedigital.co.uk http://www.northbridgedigital.co.uk/ Skype: gibsonoliver

Edzelopez commented 4 years ago

Hi @gibsonoliver

I tested the current version of the extension against a fresh 5.24.0 / D7 instance and did not notice any errors related to missing activities. One thing that probably could have happened were permissions were reset for some reason? I would check the activity permissions in Drupal again.

gibsonoliver commented 4 years ago

Hi The permissions are still the same. And the site admin who has see all Civi activities permission doesn't see them either

Like image

Do you think the upgrade may have stopped the extension working somehow?

Olly

gibsonoliver commented 4 years ago

And just looked at the log when loading a Case screen Like example.com/civicrm/contact/view/case?reset=1&id=727&cid=9&action=view On case page load the activities don't show

And the log shows

Warning: Illegal string offset 'name' in CRM_ActivityTypeACL_APIWrappers_ACL::unsetActivitySet() (line 42 of /home/portalbarcaleeds/drupal7/sites/portal.barca-leeds.org/files/civicrm/ext/biz.jmaconsulting.activitytypeacl/CRM/ActivityTypeACL/APIWrappers/ACL.php).

Edzelopez commented 4 years ago

Thanks for providing the log @gibsonoliver , I was able to fix the issue surrounding that particular piece. However, I still can't replicate the issue you are having. Could you possible provide me with more information, like names of those activity types which are missing from the contact summary? You would need to maybe disable the extension temporarily for that after backing up permissions for roles.

gibsonoliver commented 4 years ago

Hi Looks like we have resolved this issue. It looks like the upgrade (5.24) altered the way the system was looking at the resource URL civicrm root. Adjustments to this (moving to a static URL) meant the extension started again. Many thanks for looking at this

JoeMurray commented 4 years ago

Thanks Olly!