search

JMAConsulting / biz.jmaconsulting.activitytypeacl

This extension provides the ability to restrict activities on CiviCRM by roles with permissions to various activity types.
GNU Affero General Public License v3.0
4 stars 3 forks source link

Incompatible with CiviCase - configuring standard timeline or sequence #12

Closed andyburnsco closed 2 years ago

andyburnsco commented 4 years ago

When https://github.com/JMAConsulting/biz.jmaconsulting.activitytypeacl is enabled, adding and saving activities underneath the standard timeline, additional timeline or sequence fails to save, see below.

timeline

image

This prevents the use of CiviCase as you need at least the Open Case activity on the standard timeline for it to work.

I disabled all WP plugins and extensions. This extension was the culprit. Tested as super admin on WP.

seamuslee001 commented 4 years ago

Hi @andyburnsco

I have tested this on a vanilla drupal 7 and wp-demo dev site with org.civicrm.civicase and also this extension enabled. I don't see any obvious issues what permissions were you using?

activity_type_acl_1

activity_type_acl_2

andyburnsco commented 4 years ago

I am on WP. I encountered this as a super admin.

Edzelopez commented 4 years ago

I tried this on WP, with superadmin privileges as well. I was able to create activities in the standard timeline, as well as perform normal operations. Any particular errors in the log you can help us out with?

sunnycs121 commented 4 years ago

I am also seeing this issue on drupal 7. Activities do gets saved on standard timeline, but when you revisit that case type and go under standard timeline tab, they are not there.

JoeMurray commented 4 years ago

Hi @sunnycs121 could you confirm if this works when users have the Open Case permission but not if they don't?

sunnycs121 commented 4 years ago

@JoeMurray I enabled following permissions for administrator role and now seeing 'null' for each activity.

seamuslee001 commented 4 years ago

@sunnycs121 so are you using the CiviCase Extension or just the Component CiviCase?

sunnycs121 commented 4 years ago

CiviCase component

seamuslee001 commented 4 years ago

Do you have any other extensions enabled or just this one?

sunnycs121 commented 4 years ago

We have following other extensions installed:

Summary Fields Fuzion Tokens CSV GUI Import to api Angular Profiles Contact Layout Editor FlexMailer CiviDiscount Recent Items Menu CiviCRM Bootstrap theme Mosaico Mailgun

sunnycs121 commented 4 years ago

It started working for me when IF condition in function "toApiOutput" is commented out in file CRM/ActivityTypeACL/APIWrappers/ACL.php

Commented out this condition: if ($apiRequest['entity'] == 'CaseType' && $apiRequest['action'] == 'get') {

monishdeb commented 2 years ago

Moved to https://lab.civicrm.org/extensions/activitytypeacl/-/issues/12