search

JMAConsulting / biz.jmaconsulting.mte

Mandrill Emails Extension for CiviCRM
10 stars 21 forks source link

Typo: mandril_post_url in settings #109

Closed xurizaemon closed 6 years ago

xurizaemon commented 7 years ago

Typo "mandril_" has propagated through several places, could easily lead to incorrect behaviour if future code spells mandrill correctly when referencing it.

./templates/CRM/Mte/Form/MandrillSmtpSetting.tpl:       <tr class="crm-smtp-form-block-mandril_post_url">
./templates/CRM/Mte/Form/MandrillSmtpSetting.tpl:         <td class="label">{$form.mandril_post_url.label}</td>
./templates/CRM/Mte/Form/MandrillSmtpSetting.tpl:         <td>{$form.mandril_post_url.html}</td>
./tests/phpunit/Webtest/Mte/MteTest.php:    $mandrillSettings['url'] = $this->getValue('mandril_post_url');
./CRM/Mte/Form/MandrillSmtpSetting.php:    $element = $this->add('text', 'mandril_post_url', ts('Mandrill Post to URL'));
./CRM/Mte/Form/MandrillSmtpSetting.php:      $this->_defaults['mandril_post_url'] = CRM_Utils_System::url('civicrm/ajax/mte/callback',
JoeMurray commented 7 years ago

Edsel could you look after this? I think I'd like to push a new release and change status back to supported.