search

JMAConsulting / biz.jmaconsulting.mte

Mandrill Emails Extension for CiviCRM
10 stars 21 forks source link

api rest vs page for the callback? #5

Closed tttp closed 11 years ago

tttp commented 11 years ago

Reading the instruction:

Post to URL, enter the resource URL from 5 above, followed by biz.jmaconsulting.mte/CRM/Mte/Page/callback.php. For example: http://yourorg.org/civicrm/mte/callback?name=username&pass=password&key=civicrm-site-key

Isn't handling the name+pass as get param and do the authentication something drupal specific? have you tried on WP or J! ?

moreover, I didn't see where you test for the key.

Wouldn't it make sense to move all the page logic into a custom api mte.callback and so you can rely on the sites/all/modules/extern/rest.php?action=callnback&entity=mte&api_key=&key= ? So you are sure that it works as well for all the CMS,

JoeMurray commented 11 years ago

We were replicating the then best practices of using user, password and key for calling scripts in bin directory when needing authentication before doing something. We relied on the sign-in by CMS to provide the role and thus permissions. We have re-implemented this following discussion with Lobo and Tim after having errors with WP and Joomla!. See http://forum.civicrm.org/index.php/topic,28155.msg120729.html#msg120729.