JMAConsulting / biz.jmaconsulting.mte

Mandrill Emails Extension for CiviCRM
10 stars 21 forks source link

PHP Fatal error with CiviCRM 4.5.2 and Joomla 2.5.27 #61

Closed tabletguy closed 10 years ago

tabletguy commented 10 years ago

Current Joomla 2.5.27 (been running Mandril for a long time without problems). Upgraded CiviCRM to 4.5.2 and Mandrill extension to current 1.4

Scheduled jobs in CiviCRM are not running anymore. I finally found a reference to "error_log" in the /.../civicrm/ folder. It lists the following (website name changed to SITE). The following repeats for every iteration of the cron job. I have also logged in with the CiviCRM user linked to the cron job to be sure that it's password hash has been updated.

I've also just now disabled the extension and it looks like the scheduled jobs are starting to run again.

[03-Nov-2014 12:40:01 UTC] PHP Fatal error: Call to a member function get() on a non-object in /home/SITE/public_html/main/media/civicrm/custom_ext/biz.jmaconsulting.mte/mte.php on line 37 [03-Nov-2014 12:48:02 UTC] PHP Notice: Trying to get property of non-object in /home/SITE/public_html/main/libraries/joomla/application/application.php on line 173 [03-Nov-2014 12:48:02 UTC] PHP Notice: Undefined property: JException::$input in /home/SITE/public_html/main/media/civicrm/custom_ext/biz.jmaconsulting.mte/mte.php on line 37

tabletguy commented 10 years ago

One thing that might have helped finding this sooner (and I'm not an expert on cron jobs, etc. so hopefully this isn't a stupid suggestion). It would have helped if the errors were written to the standard error out, which I do capture from running php via cron.

pradpnayak commented 10 years ago

Hi tabletguy

Thanks for digging into the error. Can you please apply the patch https://github.com/JMAConsulting/biz.jmaconsulting.mte/pull/63/files and let us know if that helped?

We will include this patch in 1.5 release, which is expecting to come out this week.

HTH Pradeep

tabletguy commented 10 years ago

I am just starting a monthly newsletter mailing, so cannot do the patch for the next day or more, unfortunately.

Will the patch also direct errors to standard err?

On Mon, Nov 3, 2014 at 8:06 PM, Pradeep Nayak notifications@github.com wrote:

Hi tabletguy

Thanks for digging into the error. Can you please apply the patch https://github.com/JMAConsulting/biz.jmaconsulting.mte/pull/63/files and let us know if that helped?

We will include this patch in 1.5 release, which is expecting to come out this week.

HTH Pradeep

— Reply to this email directly or view it on GitHub https://github.com/JMAConsulting/biz.jmaconsulting.mte/issues/61#issuecomment-61486016 .

pradpnayak commented 10 years ago

The patch is a fix for notice error Undefined property: JException::$input.

tabletguy commented 10 years ago

I am testing the patch right now.

On Tue, Nov 4, 2014 at 11:55 PM, Pradeep Nayak notifications@github.com wrote:

The patch is a fix for notice error Undefined property: JException::$input.

— Reply to this email directly or view it on GitHub https://github.com/JMAConsulting/biz.jmaconsulting.mte/issues/61#issuecomment-61688823 .

tabletguy commented 10 years ago

Testing was a complete success. All scheduled jobs ran, meaning that both the Manrill extension and all following items in the schedule list worked without issue. (I.E. the patch both allowed Mandrill to run correctly AND did not seem to interfere with anything else. Not that I expected that, of course, but just reporting.

I'm not sure if I should close this, or if you keep items open until the 1.5 release, so I'm leaving that up to you, but a short comment about it would be welcome as well.

Thanks!

JoeMurray commented 10 years ago

We'll close as fixed for 1.5 version. Can you expand on what you meant by 'a short comment about it'? Kind of like a Release Notes line?

tabletguy commented 10 years ago

Sorry, I was too obscure. I meant please comment on the correct action to take regarding closing a ticket. Normally, as the initiator of the ticket, and after 'testing' the results, should I close it, or (because it was specifically mentioned), should I let the release person(s) close it when 1.5 is actually released, OR, would you (all) prefer to be closing the tickets, since you have a wider perspective on what's being done, what other platforms, etc. need testing etc. I didn't find any policies or guidelines about this on your page(s) [admitting that I didn't search that hard for them as well] Thanks -- Stephan