search

JMMC-OpenDev / OI-Imaging-JRA

Design and specification of an interface to image reconstruction and model fitting from optical interferometric data
4 stars 6 forks source link

New keyword CONVERGE #13

Closed FerreolS closed 2 years ago

FerreolS commented 2 years ago

If the software stop because it has converge, the keyword CONVERGE should be set to true in the OUTPUT PARAM table

GillesDuvert commented 2 years ago

I assumed CONVERGE is always present and is set to 0 if not converged and 1 if converged.

jsy1001 commented 2 years ago

I agree that CONVERGE should always be present. However, I think it should be a boolean.

GillesDuvert commented 2 years ago

done

jsy1001 commented 2 years ago

Done for BSMEM: https://gitlab.com/jsy1001/bsmem/-/commit/defaae14bb13ca8ae4d6756b8b3df995db9f569a

FerreolS commented 2 years ago

Thanks. @emmt ?

emmt commented 2 years ago

I assumed a boolean, hence value is 'T' (true) or 'F (false), right?

jsy1001 commented 2 years ago

I implemented T or F for BSMEM.

emmt commented 2 years ago

OK thanks, I have done the same for MiRA (see https://github.com/emmt/MiRA/commit/879a3b6eb37ec989055f4bc93df93988268ae874).

GillesDuvert commented 2 years ago

for Wisard, it is in 47c8d1f

jsy1001 commented 2 years ago

CONVERGE should be added to the specification document.