search

JMMC-OpenDev / OI-Imaging-JRA

Design and specification of an interface to image reconstruction and model fitting from optical interferometric data
4 stars 6 forks source link

WARNING keyword #16

Open FerreolS opened 2 years ago

FerreolS commented 2 years ago

From discussion in issue #12 do you think a keyword WARNING in OUTPUT PARAM containing a string with the warnings issued by the software is a good idea? I'm not sure that users will look at the log and such keyword can be useful to attract the user attention.

GillesDuvert commented 2 years ago

Indeed, looking at the log is something people do only in the most dire circumstances... The problem with the WARNING kw/value mechanism is that the value may be veeery long, e.g. a warning issued at each loop.
And it adds yet another demand to the softwares, that will not be correctly fulfilled until long, and is against our policy of adding more softwares without much trouble for their authors. I suggest the GUI scans the log for a keyword (say, "WARNING" uppercase) and inform visually that there are wanrning(s) in the log. Which will need no change for Wisard as this is already done :smile:

FerreolS commented 2 years ago

@buthanoid ? Do you think that parsing the log within OImaging is something you can implement?

buthanoid commented 2 years ago

Yes

started draft in https://github.com/buthanoid/oimaging/tree/execution-log-warning-icon https://github.com/buthanoid/jmcs/tree/icon-warning-16 it searches for a warning or error word no matter lower or upper case in the execution log and displays an icon in the tab title

emmt commented 2 years ago

We can add more conventions for tagging the log messages so that they can be automatically reported in the gui.