search

JMMC-OpenDev / OI-Imaging-JRA

Design and specification of an interface to image reconstruction and model fitting from optical interferometric data
4 stars 6 forks source link

How to prevent HDUNAME duplicates #17

Open FerreolS opened 2 years ago

FerreolS commented 2 years ago

there should be a mechanism duplication of HDU names: let say at the end of 50 iteration of a run, the final image HDU name is IMAGE-OI OUTPUT50 (as stated in sec 3.2). If the user want to continue the run for 50 more iteration, then both INIT_IMG and LAST_IMG will have the same HDU name pointing on different images. This is not possible we should define clearly how to cope with this issue.

Originally posted by @FerreolS in https://github.com/JMMC-OpenDev/OI-Imaging-JRA/issues/15#issuecomment-1055547273

jsy1001 commented 2 years ago

A possible solution would be to add a keyword (say HDUPREFX) to the input parameters, to specify the leading text to use in HDUNAME instead of IMAGE-OI OUTPUT. For example:

HDUPREFX  = 'IMAGE-OI RUN3 OUTPUT'

would result in the HDUNAME of the 50th iteration being

HDUNAME  = 'IMAGE-OI RUN3 OUTPUT50'

OImaging would be responsible for ensuring that the prefix didn't clash with any pre-existing HDUs.

FerreolS commented 2 years ago

That can be fine. We should probably also think about a fallback behaviour at least to prevent the hduname conflict between input and output is the case the reconstruction in done outside OImaging. The OI-Interface standard should be also a way to lauch reconstruction from the command line (e.g. in batch).