JMMC-OpenDev / oiexplorer

GNU General Public License v3.0

2 stars 1 forks source link

Enable excluded filtered data to appear as light grey #21

Closed jean-philippeberger closed 1 year ago

jean-philippeberger commented 1 year ago

Description

In the current version of OiFitsExplorer adding filters leads to removing data points them from the plot. This can be a problem for the user who wants to compare the effect of the selection.

Desired feature

It would be desirable to keep the plots of filtered-out data values by displaying them in a light gray colour. Removing the filter would cause those points to be colorised back.

bourgesl commented 1 year ago

It is tricky as data tables are already filtered out (no match) in the pre-processing (findOIData) so it means changing the filtering code to preserve all data tables and use EMPTY_MASKS to report invalid data in light gray...

To be discussed again, as exclusive filters or disabling filters help figuring out which data is filtered out

bourgesl commented 1 year ago

Fixed in OIFitsExplorer 0.5.1 beta 2:

Added a new toggle button 'Show/Hide' on the filter panel to either display filtered data in light gray (below valid data) or hide filtered data:

http://www.jmmc.fr/apps/beta/OIFitsExplorer/