handle multiple selection of tables (only)

buthanoid commented 2 years ago

sets Data Tree Panel's tree to discontiguous selection mode
modifies DataTreePanel.valueChanged to handle multiple tables selected, under the strict rule that they must belong to the same target and insMode. valueChanged can ask to change the selection to prune unwanted selected nodes.
modifies DataTreePanel.processSelection to handle multiple tables selected
modifies DataTreePanel.updateOIFitsCollection (called by events COLLECTION_CHANGED & ACTIVE_PLOT_CHANGED) so it correctly select multiple paths according to the subset filter which can now contain multiple tables

bourgesl commented 2 years ago

The PR changes look long, verbose and maybe over complicated...

Could you simplify the logic and the code using smaller methods ?

buthanoid commented 2 years ago

force pushing was a mistake, should have pushed a new commit.

this new version:

has a separate method to compute a subsetFilter from a list of treepath
has a separate method to compute a minimal list of treepath from a subsetfilter (code taken from function updateOIFitsCollection)

bourgesl commented 2 years ago

Looks good

JMMC-OpenDev / oiexplorer