JMMP-Group / CO_AMM15

Coastal Ocean (CO) configuration of the Atlantic Margin Model (1.5 km resolution)
4 stars 1 forks source link

Build a ME domaincfg file (on ARCHER2) #36

Closed jpolton closed 3 years ago

jpolton commented 3 years ago

Workflow to generate ME domain_cfg.nc file from scratch. Built for ARCHER2 (as a portability test)

Process documented in wiki

Acceptance criteria:

jpolton commented 3 years ago

@anwiseNOCL I think I need to hand this to you to have a play with. I written some comprehensive notes in the wiki (as above). It takes you through a complete build of the domain_cfg.nc file using ME coordinates, up to the point where it fails.... The problem is in a file called mes.F90 when it wants to broadcast arrays across all processors. I imagine it is an ARCHER2 thing, as it works for Diego on MONSooN, and would probably work on LIVLJOBS too. He has also been thinking about FORTRAN fixes. I've passed the inputs files to Diego to have a try on MONSooN, just in case it is a Jeff-error. Discussion on https://github.com/JMMP-Group/CO9_AMM15/issues/25

My goal was to get it working on ARCHER2 to make the ME tool more easy for other people adopt.

anwiseNOCL commented 3 years ago

@jpolton Ok i'll give it a go and see if i can replicate.

davbyr commented 3 years ago

@jpolton Not sure if you're still looking for a review on this but for the sake of record, it worked for me.

Issues that cropped up:

Make sure there are no NaNs in the bathymetry input. Replace with zeros using ncap2 or xarray first.

jpolton commented 3 years ago

@jpolton Not sure if you're still looking for a review on this but for the sake of record, it worked for me.

Issues that cropped up:

Make sure there are no NaNs in the bathymetry input. Replace with zeros using ncap2 or xarray first.

@davbyr I am. I ought to merge this. Since it has a file that Diego has updated. Do you have any thoughts of the different directory structures? Diego puts everything into a MEs_envs directory at the top of the tree, whereas I squirrel things into some subdirectories associated with more generic configuration building.

jpolton commented 3 years ago

@oceandie @endaodea @davbyr @anwiseNOCL I am making an executive decision to slightly restructure the code directory in order to better future proof this repository as a more permanent and evolving CO_AMM15 repo rather than a shorter lived CO9_AMM15 repository.

In reality all this means is that I've created a new high level directory to put all our excellent domain_cfg stuff into: DOMAIN_cfg/MEs_envs DOMAN_cfg/domwad

The wiki documentation works with this structure, but has not been updated/tested with Diego's most recent enhancements, but it should be fairly straight forward check/test when the next person goes through the process.