search

JMMP-Group / nordic-seas-validation

MIT License
0 stars 0 forks source link

adding new datasets #11

Closed oceandie closed 2 years ago

oceandie commented 2 years ago

This is to add the following datasets:

  1. Danmark Strait, Quadfasel_et_al_2018;
  2. Faroe-Shetland Channel, Hansen & Osterhus 2000;
  3. Iceland-Faroe Slope, Semper et al 2020
oceandie commented 2 years ago

@malmans2,

Sorry for the trivial question, how do we revolve this confict (basically that my branch now differs from the main because of your last merging)? Thanks a lot!

malmans2 commented 2 years ago

Manually in this case, not sure why GH got confused. Should be OK now!

oceandie commented 2 years ago

Manually in this case, not sure why GH got confused. Should be OK now!

That's great, thanks a lot for the support! soon I will push the last dataset and the PR will be ready for your review!

oceandie commented 2 years ago

@malmans2 ,

Ready for review! I know I could avoid some loops .. please advice if you can! :) ;)

oceandie commented 2 years ago

@malmans2, thanks for the more xarray-friendly structure!

malmans2 commented 2 years ago

@oceandie Hansen & Osterhus 2000 point to the paper. Does the dataset have a DOI? If not, where did you find the data? I couldn't figure it out quickly, so we should probably add a note/website in the README.

oceandie commented 2 years ago

@oceandie Hansen & Osterhus 2000 point to the paper. Does the dataset have a DOI? If not, where did you find the data? I couldn't figure it out quickly, so we should probably add a note/website in the README.

The dataset is actually on this technical report, tables B1.1 and B2.1 - I had to digitalise them by hand ;)