search

JMMP-Group / nordic-seas-validation

MIT License
0 stars 0 forks source link

review S2020 #14

Closed malmans2 closed 2 years ago

malmans2 commented 2 years ago
  1. Looks like Stefanie created a specific DOI for the data. The cruise is named KN203-2, so I renamed accordingly.
  2. I think we can use a method for these sections rather than a property. I didn't do it for Latrabjarg because the sections are coming from different products/cruises.
  3. I didn't sort stations and left strings to be consistent with the other sections. If strings are too annoying for the postprocessing, I guess we could use integers for the coordinate/dimension "stations", and add a "stations_id" variable for sections with named stations.
malmans2 commented 2 years ago

I think we can use a method for these sections rather than a property. I didn't do it for Latrabjarg because the sections are coming from different products/cruises.

Actually, we should probably use a method for FIM as well

oceandie commented 2 years ago

Great implementation! ;)

oceandie commented 2 years ago

I think we can use a method for these sections rather than a property. I didn't do it for Latrabjarg because the sections are coming from different products/cruises.

Actually, we should probably use a method for FIM as well

Yes I agree, I like it a lot more, I will apply the same to Q2018 (as well your approach for creating xarrays from dataframes ;) )

malmans2 commented 2 years ago

I think we can use a method for these sections rather than a property. I didn't do it for Latrabjarg because the sections are coming from different products/cruises.

Actually, we should probably use a method for FIM as well

Yes I agree, I like it a lot more, I will apply the same to Q2018 (as well your approach for creating xarrays from dataframes ;) )

@oceandie sorry, I missed this message. I changed Q2018 as well... hopefully you didn't start yet!

oceandie commented 2 years ago

I think we can use a method for these sections rather than a property. I didn't do it for Latrabjarg because the sections are coming from different products/cruises.

Actually, we should probably use a method for FIM as well

Yes I agree, I like it a lot more, I will apply the same to Q2018 (as well your approach for creating xarrays from dataframes ;) )

@oceandie sorry, I missed this message. I changed Q2018 as well... hopefully you didn't start yet!

No problem at all, better ;)