review Q2018

[malmans2]

1. Reviewed Q2018 (renamed as the others)
2. Defined a decorator to clean up all datasets and add some attribute
3. The dimension station is now empty (integers indexes), whereas the variable station_id contains strings
4. Stations are now sorted by longitude and time

I changed a few things here, so please take a look at all datasets when you get a chance.

I'll have another look as well tomorrow, just to make sure everything is in good shape.

[malmans2]

If it's of use, this is the script I'm using to check. Some of m82_1 look a bit weird, but maybe it's just the data that is quite raw?

import nsv
import matplotlib.pyplot as plt

def myplot():
    var = (
        "potential_temperature"
        if "potential_temperature" in ds
        else "through_section_velocity"
    )
    da = ds[var]
    try:
        da = da.mean("time")
    except ValueError:
        pass
    da.plot(x="distance", y="depth", center=False)
    plt.gca().invert_yaxis()
    plt.title(ds.description)
    plt.show()

property_names = [
    p
    for p in dir(nsv.Standardizer)
    if p != "raw_pooch" and isinstance(getattr(nsv.Standardizer, p), property)
]

for p in property_names:
    ds = getattr(nsv.Standardizer(), p)
    myplot()

methods = ["fim", "m82_1", "kn203_2"]
loops = [[1, 25], range(1, 10), "ABCDE"]
for method, loop in zip(methods, loops):
    for i in loop:
        ds = getattr(nsv.Standardizer(), method)(i)
        myplot()

[malmans2]

Seems fine to me. I had a look at the sections, it is true that secs m82_1(2) and m82_1(3) look a bit weird, but I think thay are just very coarse. However, I couldn't test "fim" sections since it seems https://gws-access.jasmin.ac.uk/public/jmmp/ is down ... do you know anything about it?

Can you try again? It's up now and I downloaded through the browser but I didn't try downloading through nsv/pooch.

[oceandie]

Seems fine to me. I had a look at the sections, it is true that secs m82_1(2) and m82_1(3) look a bit weird, but I think thay are just very coarse. However, I couldn't test "fim" sections since it seems https://gws-access.jasmin.ac.uk/public/jmmp/ is down ... do you know anything about it?

Can you try again? It's up now and I downloaded through the browser but I didn't try downloading through nsv/pooch.

I just tried with the phone - I can access the browser while with the metoffice laptop I cannot ... I will try to understand what is the problem ;)

[malmans2]

I just tried with the phone - I can access the browser while with the metoffice laptop I cannot ... I will try to understand what is the problem ;)

Is your neighbour at home? 🙂

[oceandie]

Should I merge? for me yes ...