search

JMMP-Group / nordic-seas-validation

MIT License
0 stars 1 forks source link

adding POS503 dataset #24

Closed oceandie closed 2 years ago

oceandie commented 2 years ago

Hi @malmans2,

Not sure why I get that pre-commit failing ... locally it worked perfectly .... any advice :) ?

malmans2 commented 2 years ago

It's this issue: https://github.com/JMMP-Group/nordic-seas-validation/issues/18 I couldn't figure out how to fix it. Basically, the documentation build by the CI is slightly different than the documentation build locally. Not sure why.

The code is fine though. Up to you, you could switch it off and remove the documentation that is automatically built.

oceandie commented 2 years ago

Thanks a lot for looking into this! Trivial question: can I ignore the failing and merge? :)

malmans2 commented 2 years ago

Yup!

malmans2 commented 2 years ago

@oceandie I noticed this dataset is missing in the README

oceandie commented 2 years ago

Yep, I'll add it today ;)