JMMackenzie / IOQP

Impact Ordered Query Processing
Apache License 2.0
3 stars 0 forks source link

Add lints and fix warnings #23

Closed lgrz closed 2 years ago

lgrz commented 2 years ago

This also fixes warning in generated protobuf types for elided_lifetimes_in_paths. It was decided to fix this in build.rs rather than allowing the elided_lifetimes_in_paths lint which must be done for the entire crate. This is why the lint wasn't added directly to src/ciff/proto.rs like all the other ones are. (actually adding elided_lifetimes_in_paths to src/ciff/proto.rs works but it produces a warning that elided_lifetimes_in_paths is crate level only.)

Another option to fix this would be to split the generated protobuf code into its own crate and enable elided_lifetimes_in_paths there, but I think that uses cargo workspaces, which seemed like overkill for this project currently.

Fixing the generated code via build.rs is brittle, but it seemed like the better option in this case.