search

JMPerez / spotify-web-api-js

A client-side JS wrapper for the Spotify Web API
https://jmperezperez.com/spotify-web-api-js/
MIT License
1.87k stars 264 forks source link

Maintainers wanted #114

Open JMPerez opened 6 years ago

JMPerez commented 6 years ago

We would like to get contributors who would like to maintain and evolve this library

As the main maintainer of this library, I have been busy lately with other projects and I will not able to keep this library up to date for the foreseeable future. I would love to get support from other contributors that have ideas on how to move forward the library so it's still relevant and useful for developers.

If you are interested in maintaining the library, please add a comment to this issue.

adamgrieger commented 6 years ago

I would love to contribute; I'm mainly a TypeScript user and I've used this library quite a bit this past year. I haven't really had experience in creating an API wrapper library, but it's definitely something I'd be interested in (especially since it's Spotify's API)!

csantiago132 commented 5 years ago

Hi! I would like to help out in any way possible! I ran into this library while working on my capstone project for my bootcamp so I would like to give back and help out in any way I can. My last three projects are with typescript so I’m getting along with it pretty well

adamgrieger commented 5 years ago

@csantiago132, I've been working on a TypeScript rewrite of this library in my spare time. If you want to help me work on it, I can push my current progress to my personal fork. I think most of the heavy lifting is done, so it's mostly supporting the rest of the endpoints, test coverage, and documentation once finished.

csantiago132 commented 5 years ago

@adamgrieger yes! Sure I’ll help out in whatever way I can. I’m wrapping up my bootcamp now so I’ll be ready to jump in in a week

adamgrieger commented 5 years ago

@csantiago132 Sounds good. I just pushed all of my changes to the typescript-rewrite branch of my fork if you want to take a look.

csantiago132 commented 5 years ago

@adamgrieger ok will take a look! ill fork it and start to get to know the codebase

adamgrieger commented 5 years ago

I added a Discord server link to my fork's README.md where we (and potentially others) can talk about the rewrite.

csantiago132 commented 5 years ago

@adamgrieger ok, ill update the branch, I went across the code and wow, great job! ill keep digging around and learn the code-base, ill start with seeing the test, i believe thats the easiest way to get to know the codebase

lynnpark commented 5 years ago

@adamgrieger @csantiago132 are you guys still actively maintaining? I'd like to try to attack #129

csantiago132 commented 5 years ago

@lynnpark id like to but havent heard from @JMPerez idk whats the best procedure or approach that he wants

adamgrieger commented 5 years ago

I probably won't be maintaining this project anytime in the near future due to work, so it's all yours if you want to take it!

lynnpark commented 5 years ago

@lynnpark id like to but havent heard from @JMPerez idk whats the best procedure or approach that he wants

Is @JMPerez the only owner? Are there anyone else with admin rights?

JMPerez commented 5 years ago

@lynnpark I'm the only owner so far

@adamgrieger, @csantiago132 would you be interested in maintaining this project?

csantiago132 commented 5 years ago

@JMPerez yes id love to!

lynnpark commented 5 years ago

@JMPerez I would love to too, if there is room for one more :)

DanielFroehlich commented 4 years ago

Hey, I am wondering what is the state of this case and project. Is it still being maintained? I am seeing a lot of good PRs also on the original repo (https://github.com/thelinmichael/spotify-web-api-node).

adamgrieger commented 4 years ago

If anyone wants to follow my progress, I've been working on an isomorphic wrapper written in TypeScript. Hopefully when it's done, it can serve as an alternative to both spotify-web-api-js and spotify-web-api-node.

https://github.com/adamgrieger/spotify-web-api-ts

BenGu3 commented 4 years ago

Just wanted to start a conversation here about a few of these packages mentioned here. I've been hoping to spend some time helping out because I'm using this package in a project. I just want to understand the future of these packages.

As far as spotify-web-api-js goes and my understanding, it looks like it may be nice to Typescript-ify this package. That would help with keeping the types and implementation in sync by letting tsc create the type definition files. (I'd be glad to help with this).

It seems like spotify-web-api-node hasn't been touched in a year or two.

I know as far as Typescript goes, @adamgrieger has made huge progress on spotify-web-api-ts, which is great because that could be used in place of both spotify-web-api-js and spotify-web-api-node. I'd be glad to help out there also, though it seems redundant having all of these packages.

I'd love to hear everyone's thoughts and ideas about all this.

JMPerez commented 4 years ago

@BenGu3 Happy to typescript-ify this project, that would help with maintenance. It's painful adding new endpoints due to having to modify many files when one would expect changing the lib + test.

If you can explore this approach, I'd be glad to review the changes and make a decision. The overhead for the library output will be minimal. Once the JS is generated it shouldn't be that large compared to the current bundle, and adding a couple of kBs is good trade-off if that makes it easier to keep updated.

Regarding @adamgrieger's project, the more the merrier. I can't commit to maintaining more projects at the moment, but I can reach out to the Spotify team to try to list it in their list of wrappers for developers to discover.

patrick-motard commented 4 years ago

How does this repo relate to https://github.com/thelinmichael/spotify-web-api-node ? When I initially searched for a spotify sdk in nodejs on NPM, that was the version i found.

It looks like this repo is what is actually keeping https://www.npmjs.com/package/spotify-web-api-node up to date. But the links to source code on that page link to https://github.com/thelinmichael/spotify-web-api-node. Maybe those links should be updated to point to this project?

Will https://github.com/adamgrieger/spotify-web-api-ts be merged into this project in the future?

There are several new issues and pull requests being submitted to https://github.com/thelinmichael/spotify-web-api-node but it's not being updated and doesn't get pubished to NPM. IMO it's issues should be closed and/or moved to this project.

patrick-motard commented 4 years ago

Ah... I think I see what is going on now. Not sure how I missed this before. These are two separate projects.

Given that my project is in Electron, I'm assuming I want to be using the other project. Though it's confusing to me why https://github.com/thelinmichael/spotify-web-api-node claims:

This is a universal wrapper/client for the Spotify Web API that runs on Node.JS and the browser

If it can be used in the browser, and JMPerez is a maintainer of it why does spotify-web-api-js exist?