search

JMS55 / bevy_dioxus

Apache License 2.0
56 stars 8 forks source link

Documentation and cleanup #8

Open JMS55 opened 8 months ago

JMS55 commented 8 months ago

Open questions:

robertdodd commented 8 months ago

Event and Component are the biggest conflicts.

In my usage I've tried renaming imports so I can do dx::Event, but I'd prefer if they all came from bevy_dioxus::prelude::*, or maybe from bevy_dioxus::dioxus_types::*.

I've tried searching about correct patterns for doing this, but haven't found any standard answer yet. In my opinion, without knowing any better, I'd image that bevy_dioxus::dioxus_types::* exports everything but renames only the conflicting types (e.g. DioxusEvent, DioxusComponent, widget).

JMS55 commented 8 months ago

What do you use Component for? But yeah I'll probably rename Event and #[component].

robertdodd commented 8 months ago

I was wrong, Component isn't an issue :)

ekowoii commented 8 months ago

Event and Component are the biggest conflicts.

In my usage I've tried renaming imports so I can do dx::Event, but I'd prefer if they all came from bevy_dioxus::prelude::*, or maybe from bevy_dioxus::dioxus_types::*.

I've tried searching about correct patterns for doing this, but haven't found any standard answer yet. In my opinion, without knowing any better, I'd image that bevy_dioxus::dioxus_types::* exports everything but renames only the conflicting types (e.g. DioxusEvent, DioxusComponent, widget).