search

JMSLab / Template

Template for research repository using scons.
9 stars 1 forks source link

Pull request for #45: Cloning with git lfs #48

Closed santiagohermo closed 2 years ago

santiagohermo commented 2 years ago

Can you review this brief PR @jmshapir @mcaceresb @veli-m-andirin?

In #45 we detected a problem when cloning repositories created via the Template option using JMSLab/Template. We discussed solutions. In the end, we decided to drop the binaries and gitignore them, so that we can still take advantage of the "Template" option.

jmshapir commented 2 years ago

@mcaceresb on the below, thanks, and yep, this seems like an ok default to me.

@jmshapir I wanted to flag that .eps files are not being tracked by git lfs; unsure whether this was by design or not (since .pdf and .png are under git lfs).

santiagohermo commented 2 years ago

Thanks all! I'm also good with the changes implemented by @jmshapir, so I'll proceed to wrap up this issue.

santiagohermo commented 2 years ago

Summary here

jmshapir commented 2 years ago

Thanks @santiagohermo! Now that results are merged, do you want to try another clone test like you did in https://github.com/JMSLab/Template/issues/45#issuecomment-1024980394, just to confirm that we can now spawn a repository from the Template and clone without issues?

santiagohermo commented 2 years ago

Thanks @santiagohermo! Now that results are merged, do you want to try another clone test like you did in #45 (comment), just to confirm that we can now spawn a repository from the Template and clone without issues?

Great point @jmshapir! I tested cloning a repo spanned from the updated template under my name, as before. I did so only with GitHub Desktop. I didn't get any errors, and I was even prompted to initialize git lfs after cloning. So that's great!

Btw, while going through this process I noticed an empty rscript.log file. I assume this is unintentional? I could delete directly from master, or we could wait and remember to delete it when a new branch opens up.

image

jmshapir commented 2 years ago

Great point @jmshapir! I tested cloning a repo spanned from the updated template under my name, as before. I did so only with GitHub Desktop. I didn't get any errors, and I was even prompted to initialize git lfs after cloning. So that's great!

@santiagohermo excellent news! Thanks for opening #45 so we could squash this bug!

Btw, while going through this process I noticed an empty rscript.log file. I assume this is unintentional? I could delete directly from master, or we could wait and remember to delete it when a new branch opens up.

I'm not sure but if @veli-m-andirin agrees that this is unintentional, maybe @veli-m-andirin can open a new issue assigned to @rcalvo12 to remove it?