search

JMSLab / Template

Template for research repository using scons.
9 stars 1 forks source link

Allow for different logfile encodings #92

Closed rcalvo12 closed 8 months ago

rcalvo12 commented 8 months ago

This issue is a follow up of #76 :

If the sconscript.log file has characters that are not in "utf-8", scons breaks. This is particularly a problem when parallelizing the build. A simple fix would be allowing the builder to try again with "latin1" if it doesn't read "utf-8" on the first pass.

We closed that issue because we were unable to recreate the issue while trying to produce unit tests. However, we have now experienced the bug in a separate projects so we will reimplement the change here.

rcalvo12 commented 8 months ago

Thread continues in #93.

rcalvo12 commented 7 months ago

Summary:

In this issue, we provided a fix to the builder so it will write the sconscript.log file with "latin1" characters if it doesn't read "utf-8" on the first pass.

Merged in https://github.com/JMSLab/Template/commit/466a62f9b99159f19c99984aec9a6af1b140389d. Final state of issue branch here.