search

JMSLab / Template

Template for research repository using scons.
9 stars 1 forks source link

PR for #98 add [update open branches from main after completing a PR] to workflow #99

Closed zhizhongpu closed 3 months ago

jmshapir commented 3 months ago

@zhizhongpu thanks!

I made a few tweaks in 4c9e1e8. Let me know if any concerns.

Otherwise, it looks like we have some failures in macos build testing. (At least one ubuntu test has passed though.) I think it's very unlikely to be related to the change we made here, so I wonder if we need to update our syntax for github actions.

Can you look into it?

jmshapir commented 3 months ago

@zhizhongpu can you let me know our status here?

It's possible I may be able to ask someone else to jump in to help.

Thanks.

zhizhongpu commented 3 months ago

@zhizhongpu can you let me know our status here?

It's possible I may be able to ask someone else to jump in to help.

Thanks.

thanks @jmshapir - I've not started on this yet

jmshapir commented 3 months ago

@zhizhongpu thanks!

I'm coassigning @ew487. For now we can plan that whoever gets to this first (@zhizhongpu or @ew487) can work on it.

I will be in touch separately about how best to prioritize this with other work.

@ew487 please see https://github.com/JMSLab/Template/pull/99#issuecomment-2108415188 for where we left off here.

zhizhongpu commented 3 months ago

@jmshapir Problem seems to be that GitHub actions' macos-latest module is now arm-based (no more x86). I tested 3 solutions proposed on the Internet:

  1. [proven to work] change macos-latest to macos-13 i.e. bc8f78bd0d481655495eca964dee8c359d5aadde and 63af2a371b49004146cdc3d7e09f899b0d79bd58
  2. [proven to work] remove architecture request i.e. 95c2b2cfed2bbcd382aa95024b8fec5ae2c03a92
  3. [proven NOT to work] use higher versions of python i.e. 977f5dac607429d308d4b1e941a462807defe88e

@jmshapir lmk your thoughts. I'm not sure what the goal of these checks are, but if you have questions on the specific implications of (1) or (2) I'm happy to dig deeper.

fyi @ew487

Read More

https://github.com/actions/setup-python/issues/825 https://www.reddit.com/r/github/comments/1cjiat4/is_github_actions_macoslatest_now_only_armbased/

jmshapir commented 3 months ago

@zhizhongpu thanks!

I'm not sure what the goal of these checks are,

The goal is to increase our confidence that the builders work on a variety of systems.

@jmshapir lmk your thoughts.

Let's go with (2). Let me know when it's implemented in the main issue branch here, thanks!

zhizhongpu commented 3 months ago

0b933586f0a15f427f453b7cb8c57ff6da38a157 implements (2) and passed all checks. @jmshapir lmk if I can merge - thanks.

jmshapir commented 3 months ago

@zhizhongpu clear to merge thanks!