Closed jmshapir closed 1 year ago
Thanks @jmshapir! I'll explore github actions and post here when I make some progress.
Updates @jmshapir @nateschor:
The new workflow runs appear in actions/workflows/check-standard.yaml
instead of actions/workflows/R-CMD-check.yaml
. (It looks like when I run usethis
the name of the file changed.
devtools::check()
. I will change code to get rid of those warnings, and see if the checks pass after.New updates @jmshapir @nateschor:
/vignettes/
folder to suppress the second warning
The latest run is here. As you can see it ran without problems, so I think we are ready to go to PR.
Thanks @santiagohermo! Going to PR sounds good to me.
Figuring out the proper way to incorporate the vignette is on my to-do list for #28 :)
Continues in #30
Summary: In this issue we implemented GitHub Actions. We also prepared the release of eventstudyr 1.0.1
in the PR #30.
Changes merged to master in https://github.com/JMSLab/eventstudyr/commit/1ff2c0375d8086a5103f5458bdbbcae6c639e28f.
@santiagohermo now that the package is live I think we're at a good point to reenable Github Actions.
See https://github.com/JMSLab/eventstudyr/pull/12#issuecomment-1362024237 for context.
My guess is the most natural framework for us to use is
r-lib/actions
v2 but you can let me know if you conclude otherwise.@nateschor fyi.