Closed nateschor closed 1 year ago
@santiagohermo @nateschor are the only open threads here those that relate to https://github.com/ryanedmundkessler/suptCriticalValue/issues/2? If so maybe @santiagohermo can approve the pull for bookkeeping purposes?
@jmshapir according to this repo people have been rejected from CRAN for:
I addressed both of these in https://github.com/JMSLab/eventstudyr/pull/32/commits/739f0bef59b7ee3349fc660dad8c77db20603db3.
Can you confirm that you're okay with these changes? I'll wrap up this PR afterwards! My plan is then to:
fyi @santiagohermo
In #28 we prepared the package for initial submission to CRAN. The tasks we completed as well as potential follow-up issues are in the opening comment.
@jmshapir two things to draw your attention to during review are:
PrepareLeads()
andPrepareLags()
as internal functions, see https://github.com/JMSLab/eventstudyr/issues/28#issuecomment-1490532121@SimonFreyaldenhoven @ew487 @rcalvo12 fyi