JMSLab / xtevent

Stata package -xtevent-
MIT License
44 stars 12 forks source link

Emphasize -impute- option #103

Closed jorpppp closed 2 years ago

jorpppp commented 2 years ago

We have received a few questions about the impute option in xtevent 2.0.0. I think we need to make this change more visible.

@Constantino-Carreto-Romero will:

jorpppp commented 2 years ago

@Constantino-Carreto-Romero still working on this.

jorpppp commented 2 years ago

@Constantino-Carreto-Romero still working on this.

jorpppp commented 2 years ago

Pending.

jorpppp commented 2 years ago

Pending, should be done this week @Constantino-Carreto-Romero

Constantino-Carreto-Romero commented 2 years ago

@jorpppp, on the home page,

jorpppp commented 2 years ago

Per call:

Bold: To produce equivalent results as with xtevent 1.0.0, where the default was to impute the endpoints, the user should use impute(stag). Then, explain what the impute option does (combine the two explanations).

jorpppp commented 2 years ago

@jorpppp will review the note about the impute option here: https://raw.githack.com/JMSLab/xtevent/issue103_emphasize_impute_option/issue103/impute_option_description.html

This markstat package seems useful, we could use it for the examples on the home page.

jorpppp commented 2 years ago

Per call: It would be good to have the math behind this.

Constantino-Carreto-Romero commented 2 years ago

In https://github.com/JMSLab/xtevent/commit/fe7fd51efdd0b06b7768b617babd9ce53cbff294 I implemented https://github.com/JMSLab/xtevent/issues/103#issuecomment-1284192661

It is pending https://github.com/JMSLab/xtevent/issues/103#issuecomment-1289525176

Edit: for future reference, this is the tutorial I followed about the markstat package

jorpppp commented 2 years ago

@Constantino-Carreto-Romero implemented the last formatting edits for these examples, so we are ready to pull.

Edit: Before pulling, we'll open a new issue for the documentation behind the impute option. We'll move the draft of the documentation file there, and we'll delete the issue folder here before PR.

Constantino-Carreto-Romero commented 2 years ago

Summary: In this issue, we added a paragraph on the home page to emphasize the -impute- option and created an HTML file describing this option.

Thread continues in https://github.com/JMSLab/xtevent/pull/121