search

JMSLab / xtevent

Stata package -xtevent-
MIT License
43 stars 12 forks source link

Typo in xteventplot #130

Closed Constantino-Carreto-Romero closed 1 year ago

Constantino-Carreto-Romero commented 1 year ago

Per comment https://github.com/JMSLab/xtevent/issues/109#issuecomment-1440266068 in #109, there is a typo in xteventplot in line https://github.com/JMSLab/xtevent/blob/da196cc2d1b93ed3d9904a796fbcbec428d30b1c/xtevent/xteventplot.ado#L932

jorpppp commented 1 year ago

Thanks @Constantino-Carreto-Romero @santiagohermo. Looks like an easy fix but let me check if this is affecting anything else.

jorpppp commented 1 year ago

I fixed this in https://github.com/JMSLab/xtevent/commit/5ef9104fd14cd88b507730a9c8c71f28749daade. Seems like this is not affecting anything else because this Wald value is not used later in the code, but we should keep it for future bug checking just in case.

jorpppp commented 1 year ago

Summary: In this issue we fixed a typo in xteventplot regarding a Wald value. This does not affect any other calculation in the code.

Thread continues in #133