search

JMSLab / xtevent

Stata package -xtevent-
MIT License
43 stars 12 forks source link

Issue126 excluding units but eventtime is defined #139

Closed jorpppp closed 1 year ago

jorpppp commented 1 year ago

Closes #126

jorpppp commented 1 year ago

We need to test everything again to make sure no errors were created by using this dual-sample approach with mark for _eventgenvars and marksample for the rest. I think any possible errors will show up during testing, it mostly boils down to making sure we have touse everywhere it's needed.

Do not forget to erase the issue folder at the end.

jorpppp commented 1 year ago

All the test results between the main branch and this one are identical. I'll now test the examples in the issue folder.

jorpppp commented 1 year ago

The fix did not work unless I also implented mark in xtevent.ado. With this fix the tests here do not drop any cross-sectional units. Looks ready to pull!