search

JMSLab / xtevent

Stata package -xtevent-
MIT License
43 stars 12 forks source link

#163 incorporate in help files edits from paper #164

Closed Constantino-Carreto-Romero closed 11 months ago

Constantino-Carreto-Romero commented 11 months ago

Closes #163

jmshapir commented 11 months ago

@Constantino-Carreto-Romero thanks!

Reassigning @jorpppp as reviewer here.

jorpppp commented 11 months ago

Thanks @Constantino-Carreto-Romero

I don't want to hold us up here and I can't get to this until late next week.

Maybe @jorge-emilio-melendez can help us review here with a set of fresh eyes?

@Constantino-Carreto-Romero can you coordinate with him please?

@jmshapir FYI

On Fri, Oct 6, 2023, 8:51 AM jmshapir @.***> wrote:

@Constantino-Carreto-Romero https://github.com/Constantino-Carreto-Romero thanks!

Reassigning @jorpppp https://github.com/jorpppp as reviewer here.

— Reply to this email directly, view it on GitHub https://github.com/JMSLab/xtevent/pull/164#issuecomment-1750620642, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBUYUEYZ2TD6XCQMVBCGMTX575EDAVCNFSM6AAAAAA5VK74K6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGYZDANRUGI . You are receiving this because you were mentioned.Message ID: @.***>

jorge-emilio-melendez commented 11 months ago

I checked that the help files and what the paper says matched each other. It seems that everything is in order.

jorpppp commented 11 months ago

Thanks @jorge-emilio-melendez. @Constantino-Carreto-Romero ,can you wrap up and then draft a release, please?