search

JMSLab / xtevent

Stata package -xtevent-
MIT License
43 stars 12 forks source link

PR for #165: prepare release xtevent 3.0.0 #168

Closed Constantino-Carreto-Romero closed 6 months ago

Constantino-Carreto-Romero commented 7 months ago

Closes #165

jorpppp commented 7 months ago

@Constantino-Carreto-Romero I was reviewing the PR and found this issue with reghdfe: https://github.com/JMSLab/xtevent/issues/165#issuecomment-1894629559

I think it would be a good idea to switch xtevent's default behavior to try to install the Github version of reghdfe first. If that doesn't work, issue a warning and install the ssc version. Do you think you can implement that change?

jorpppp commented 7 months ago

@Constantino-Carreto-Romero Have you had the chance to look at these pending changes?

Constantino-Carreto-Romero commented 6 months ago

@Constantino-Carreto-Romero I was reviewing the PR and found this issue with reghdfe: #165 (comment)

I think it would be a good idea to switch xtevent's default behavior to try to install the Github version of reghdfe first. If that doesn't work, issue a warning and install the ssc version. Do you think you can implement that change?

@jorpppp I checked again the problem I mentioned in https://github.com/JMSLab/xtevent/issues/165#issuecomment-1894629559. That time I found as solution to install ivreghdfe along with its dependency (reghdfe) using the latest GitHub versions (instead of the ssc versions). I revised this problem again and found that it is enough to only install the Github version of ivreghdfe, so reghdfe can be installed as the ssc version. By doing this, I run the test file without problems.

I think it would be a good idea to switch xtevent's default behavior to try to install the Github version of reghdfe first. If that doesn't work, issue a warning and install the ssc version. Do you think you can implement that change?

At first, I implemented it as indicated, but since the dependency file is a do-file and not an ado-file, it always printed the warning's text. Then, I only added some commented text to the dependency file in https://github.com/JMSLab/xtevent/pull/168/commits/4a55e790872e6a3c65c480bd2a8fc7810c9e177c

jorpppp commented 6 months ago

@Constantino-Carreto-Romero thanks! This looks like it's ready to release!

jmshapir commented 6 months ago

@Constantino-Carreto-Romero @jorpppp fyi that the release is still in draft status. It won't appear as most recent until it is published.

Thanks!

jorpppp commented 6 months ago

@Constantino-Carreto-Romero @jorpppp fyi that the release is still in draft status. It won't appear as most recent until it is published.

Thanks!

Thanks @jmshapir ! Your comment caught us in the middle of publishing the release. It should be published now. We pushed forward today to have a baseline for the upcoming changes.