Closed Constantino-Carreto-Romero closed 4 months ago
@jorpppp
window
's description in the help file and added an example. Thank you @Constantino-Carreto-Romero. I left some comments on https://github.com/JMSLab/xtevent/commit/480ba3c017e3e6cca0df345eeb4e6cd20bf0d33d to be addressed. Please let me know when you review them and I'll take another look.
@Constantino-Carreto-Romero can you also check the documentation to possible make the explanation of window
clearer? Users may not understand why if they have event times -5 to 5, they cannot use window(-5 5)
. This is because of the endpoints: we should make this clearer.
Thank you @Constantino-Carreto-Romero. I left some comments on 480ba3c to be addressed. Please let me know when you review them and I'll take another look.
@jorpppp thanks
in that same commit https://github.com/JMSLab/xtevent/commit/480ba3c017e3e6cca0df345eeb4e6cd20bf0d33d I addressed each comment.
in https://github.com/JMSLab/xtevent/commit/7c67683a6587f0bb0f8f715fa52b989b63c6dd9a I addressed the comment in https://github.com/JMSLab/xtevent/issues/170#issuecomment-2035206257.
After the changes, I ran the test file and found a conflict when estimating static models. The window parser was activated when the user asked for a static model. In https://github.com/JMSLab/xtevent/commit/4017f257e8d458f2e60f9b8be8ce681f63f71865 and https://github.com/JMSLab/xtevent/commit/80e8a07006ab8b9f1caeba9d8c7e47c79c3395ce I added some changes to overcome this conflict.
After this, I ran the test file and the file in the issue folder without inconvenience. I checked that the help file was rendered correctly as well.
Summary: In this issue, we implemented automatic window generation if the policy variable follows staggered adoption. Thread continues in https://github.com/JMSLab/xtevent/pull/178
Modify the -window- option to admit the following specifications if the policyvar follows staggered adoption:
window(max)
: use for the estimation window the greatest event-time limits found in the datasetwindow(balanced)
: use for the estimation window the greatest event-time limits that allow using a balanced panel.