PR for #179 Check behavior of the cohort and control_cohort options and allow automatic generation

JMSLab / xtevent

Stata package -xtevent-

MIT License

43 stars 12 forks source link

PR for #179 Check behavior of the cohort and control_cohort options and allow automatic generation #185

Closed jorpppp closed 3 months ago

jorpppp commented 3 months ago

Closes #179

jorpppp commented 3 months ago

@Constantino-Carreto-Romero Can you spend some time testing these new cohort and control_cohort options, trying to break them to see if we find any bugs before merging please?

jorpppp commented 3 months ago

Note the branch was brought up to date in https://github.com/JMSLab/xtevent/commit/a01bc146156691921370243435ab6f8f44010048 and https://github.com/JMSLab/xtevent/pull/185/commits/09f3637366d850b0683e41cf0dadb258676a3a0e

Constantino-Carreto-Romero commented 3 months ago

@jorpppp I finished testing

implementation (cohort,control_cohort and sunabraham options).
interaction of the new options and the rest of the options.
That the rest of the options keep working.

I attach the do-file I built while testing those points. I had also revised all the new code to be able to solve PR’s conflicts, but I see you have solved them, thanks.

jorpppp commented 3 months ago

Thanks for the review @Constantino-Carreto-Romero, this looks good. Merging the PR now.