JMSLab / xtevent

Stata package -xtevent-
MIT License
43 stars 12 forks source link

Error when normalizing `0` coefficient #186

Closed jmshapir closed 3 months ago

jmshapir commented 3 months ago

I'm getting an error when trying to set norm(0).

Below is a MWE based on the example in the help file.

Very possible this is just user error but wanted to flag in case not!

norm0.log norm0.zip

jorpppp commented 3 months ago

@jmshapir Thanks, this looks like a bug, I was able to replicate it. I will start a branch to fix it.

jorpppp commented 3 months ago

@jmshapir Should be fixed now, starting a PR. @Constantino-Carreto-Romero FYI

jorpppp commented 3 months ago

Summary: In this issue we fixed a bug where the temporary copy of the normalized event-time dummy was only generated correctly if the normalized coefficient corresponded to negative event-time.

Thread continues in #187