JMSLab / xtevent

Stata package -xtevent-
MIT License
43 stars 12 forks source link

188 left window of zero returns an error #194

Closed jorpppp closed 3 months ago

jorpppp commented 3 months ago

Closes #188

jorpppp commented 3 months ago

In https://github.com/JMSLab/xtevent/pull/194/commits/f52d1de14114f784c79ffef2c16f1791cb92a1d1 I disabled the smoothest path calculation if the left window is zero.

jorpppp commented 3 months ago

@Constantino-Carreto-Romero I tested for a few more things that could lead to issues with a left window of zero and added some modifications:

I think that's it for possible issues with a left window of zero so I'm merging the PR. We can revisit later if we realize something else is amiss when testing for the release.