JMitnik / haas

haas
0 stars 0 forks source link

Dashboard: Component cleanup #397

Closed JMitnik closed 2 years ago

JMitnik commented 2 years ago

Closes HAAS-321

The last months introduced a bunch of new components, and let a lot of "extra" code dangle. A cleanup was necessary.

This PR does a few things:

I also added a link to a new documentation, which highlights a generic API for how our Common components can be used form now on: https://www.notion.so/jmitnik/Common-Components-6d9ac2807c1641aab98a26f039cc85a0

linear[bot] commented 2 years ago
HAAS-321 WorkspaceGrid: Code Cleanup

## Description The code has been a bit left without care (due to the speed of things). A few thigns need to be cleaned: * [ ] Clean the loose Popovers and straighten them out throughout the major codebase * [ ] The side paddings.

aws-amplify-eu-central-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-397.d36c61y3h9mqcx.amplifyapp.com

Cold-A-Muse commented 2 years ago

Was it intentional to merge scroll-to-top with this PR instead of DEV 🤔 ?

JMitnik commented 2 years ago

Yep, I had based it (accidentally) on this branch so to keep the diffs clean I would do that