Closed Cold-A-Muse closed 2 years ago
Few notes:
dateString
. This accepts three formats: '"dd-MM-yyyy HH:mm", "dd-MM-yyyy" or ISO format. It can still be improved (throw error if it does not match), but I think this is a good start; if we use common fields like these, we should think in terms of custom scalars
.graphql
extension (e.g. Issue.graphql.ts
). Makes it easier to filter (also away from dashboard files)NexusGenField['blabla']
by putting exports of the types in the relevant XTypes
file. So instead of NexusGenField['Session']
, I have a file Session.types.ts
(atm called SessionTypes
), which exports export type Session = NexusGenField['Session']
; this makes it cleaner and easier to potentially refactor/extend Nexus types.buildFindWorkspaceSessionsQuery
, this is purely internal to the SessionPrismaAdapter). Those private
methods go to the bottom of the file. Public methods go to the top, and are the ones we expect to expose to other classes. So also, dependencies like prisma: PrismaClient
should likely stay private.A few more thigns would be good to have here:
followUpAction
withFollowUpAction
in the filterI added both followUpAction and withFollowUpAction @JMitnik
In this PR
Use search field to filter based on topics Use dialogueIds field to filter based on team(s) Use scoreRange field to filter based on score
Example Query
Example input