JMitnik / haas

haas
0 stars 0 forks source link

Feat/filter workspace grid by accessible dialogues #443

Closed Cold-A-Muse closed 2 years ago

Cold-A-Muse commented 2 years ago

First merge multi-step PR ‼️

In this PR: Add functionality where only assigned/public dialogue data can be accessed within the Workspace Grid Add @radix-ui/react-context-menu for an improved version of our current context menu Add option within Generate Workspace View to make all dialogues public/private initially Add make dialogue/team private test for Generate Workspace Resolver Add front-end test for DialogueOverview

Fixes HAAS-406 https://linear.app/haas/issue/HAAS-406/dashboard-overview-for-only-the-assigned-teams

Running into some issues with mocks not being cleared and leaking over into other tests I think. Sometimes they work and sometimes they don't which is a bit strange haha

linear[bot] commented 2 years ago
HAAS-406 Dashboard overview for only the assigned teams

If you are a company manager and the workspace has 30 teams, you only manage (and have access to) 10 teams. The Dashboard aggregate should only give you the insights and stats of the 10 teams you manage. TODO: * [X] Filter out dialogues from workspace grid based on userId (Private dialogues) [46d8b447-67fc-46ca-81d9-8a55fb7fb384](https://uploads.linear.app/70b977a1-9bb5-4bc6-adbd-96d04979709e/08f8e6a1-de0e-4fc4-bee1-c59789d3000d/46d8b447-67fc-46ca-81d9-8a55fb7fb384) * [X] Add assign to sub menu to dialogue card * [X] Double check whether assign/un-assign works properly * [X] Add @radix-ui/react-context-menu for an improved version of our current context menu * [X] add managers BEFORE dialogues creation * [X] Add option within Generate Workspace View to make all dialogues public/private initially * [X] Add make dialogue/team private test for Generate Workspace Resolver * [X] Check if you can assign same user to multiple teams in group CSV

aws-amplify-eu-central-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-443.d36c61y3h9mqcx.amplifyapp.com

aws-amplify-eu-central-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-443.d2j37lx5gsfgp1.amplifyapp.com

JMitnik commented 2 years ago

Build is still broken, @Cold-A-Muse you know why?

Cold-A-Muse commented 2 years ago

Build is still broken, @Cold-A-Muse you know why?

Running into some issues with mocks not being cleared and leaking over into other tests I think. Sometimes they work and sometimes they don't which is a bit strange haha

Cold-A-Muse commented 2 years ago

@JMitnik Fixed I think

JMitnik commented 2 years ago

Conflicts should be resolved here

JMitnik commented 2 years ago

I'll have a look at this, no need to cry anymore