Open JMurk opened 8 years ago
Does Jun have bandwidth to complete the Admin items?
Jun, please see above for issue description. This may require a field to be added to the database, which I will take care of when you are ready to make the update.
Updated on dev.
Confirmed complete on dev.
Yousif - Please update the application so the Organization field in the Hydrant_Status table (and UX form) is auto-populated using the Organization defined for the user in the Admin tool (cityUsers database).
which db this new field is in? what is the organization field name?
cityUsers.User.Organization
For inspection organization, these are the values expected for 'INSP_ORG' in the app: FD => 'Baltimore Fire Dept.' DPW => 'Baltimore DPW' WA => 'Wachs' BACO => 'Baltimore County' NA => 'Not Applicable'
I will implement the funtionality in the web service to return cuurent inspection organization. Can you provide the work-flow for auto-populating the inspection organization? What to disply in the app if organization field not set in db (null value)? What to disply in the app if organization field is set but not in the app lookup values above (FD, DPW, ...)?
Please find the response below in red text:
We need to add 'Organization' field to 'cityUsers.UsersView' view for the web service to return it. Let me know when 'Organization' field added to view
Hi Yousif - Please retrieve this value from the dbo.User.Organization attribute field, rather than the one noted above.
Completed and ready for testing on DEV
I apologize for the need to revise - however, the user workflow to add a new hydrant status has been modified from the process originally described above.
Please update the system to automatically populate the Inspector Organization value immediately the user clicks/taps the New button (shown in green within the updated workflow below):
This is already apply to current code on DEV. Can you confirm its work flow?
Hi Jun - it appears that the Organization Field in the Admin Portal is not editable. I am able to update the text within the field but the changes do not commit to the database.
I checked the code, and it seems my code was overwritten yesterday.
Hi Yousif, after you merged code this morning, you should update the code again, since the update you did yesterday didn't include the diffs.
I updated 4 codes before: Controllers/RolesController.cs Controllers/UsersController.cs Models/User.cs UserRoleInfo.cs
I will rebuild the code, which includes all the our updates before. And update it on dev.
Code updated on DEV. All the updates should be on dev now.
I am still unable to successfully validate the workflow because the system is not automatically pre-populating the Inspector Organization value after the user clicks the New button.
Yousif - Please reference the attached file to validate the front-end code against the workflow
The front-end app will not auto populate the organization unless the db organization field populated with one of the following: FD => 'Baltimore Fire Dept.' DPW => 'Baltimore DPW' WA => 'Wachs' BACO => 'Baltimore County' NA => 'Not Applicable'
The front-end app will set the value to null for any other organization code!
I was able to successfully validate the auto-populate functionality in development. This issue will be updated to "Ready for Production".
Update Description: Add a column for Organization to the users table and only show in the valve & hydrants app.
Once in place, use this field to autopoulate the INSP_ORG field in the Hydrant_Status table.