JMurk / Valve_Hydrant_Mobile_Issues

Water Valve Status Mobile Issues
0 stars 0 forks source link

Hydrant Status: missing fields #47

Open rssidlowski opened 8 years ago

rssidlowski commented 8 years ago

Missing the following fields: Missing/Damage Cap? CSR ID SR ID Work Order ID

yousifmalik commented 8 years ago

Please provide more details about these missing fields. Where to place them? which fields in db they map too?

yousifmalik commented 8 years ago

hydrant 1 hydrant 2

rssidlowski commented 8 years ago

It should be 'Missing/Damaged Cap?' and place after 'Missing/Damaged Chains?'. The other fields should be after Pitot (PSI).

Scott, can you see if these fields are in the database?

yousifmalik commented 8 years ago

Currently, I have the following fields mapping: CRS ID -> CSR_SR_NUM SR ID -> CW_SR_NUM Work Order ID -> WO_NUM Please verify if this mapping

JMurk commented 8 years ago

And Missing/Damaged Cap -> MISSING_CAP_YN

The others you noted are correct.

slmessier commented 8 years ago

Yousif - Please also update the SR ID & Work Order ID attribute values to function as hyperlinks using the specifications described below:

UX Example (note the green box): image

SR URL Text & Example (UX passes ID value into URL string): https://dpwapps.baltimorecity.gov/Cityworks/Login.aspx?ReturnUrl=%2fCityworks%2fWorkManagement%2fRequestEdit.aspx%3fRequestId%3d218108&RequestId=218108 image

Work Order URL Text & Example (UX passes ID value into URL string): https://dpwapps.baltimorecity.gov/Cityworks/Login.aspx?ReturnUrl=%2fCityworks%2fWorkManagement%2fWoGeneralEdit.aspx%3fWorkOrderId%3d293183&WorkOrderId=293183 image

yousifmalik commented 8 years ago

Ok, How do we want to display CRS ID, SR ID, and Work Order ID? are they suppose to be on their own section (Associated Work Activities)? Is "CSR ID" field read-only?

slmessier commented 8 years ago

Yes these new attributes should be presented within a distinct container / section within the UX as visualized within the graphic / mockup above.

CSR ID is not read-only. it should remain editable, however the hyperlink functionality does not need to be applied to that item.

yousifmalik commented 8 years ago

Ready for testing on DEV

slmessier commented 8 years ago

Thanks Yousif - I can confirm that the hyperlink functionality is working however the hyperlink is not linking to the correct URL's. The hyperlink is currently erroneously linking to the Valve/Hydrant URL.

Please update the target URL for the SR ID and Work Order ID hyperlinks to utilize the correct URLs appropriately. The URL's are provided above within this issue, note each has a distinct URL.

I am using Hydrant # 152C010003 to test. you can reference the 2 most recent inspections for that hydrant to validate.

yousifmalik commented 8 years ago

I am setting the following URLs where the {id} will be replace by the actual ID value: For "SR ID", https://dpwapps.baltimorecity.gov/Cityworks/Login.aspx?ReturnUrl=%2fCityworks%2fWorkManagement%2fRequestEdit.aspx%3fRequestId%3d{id}&RequestId={id}

For "Work Order", https://dpwapps.baltimorecity.gov/Cityworks/Login.aspx?ReturnUrl=%2fCityworks%2fWorkManagement%2fWoGeneralEdit.aspx%3fWorkOrderId%3d{id}&WorkOrderId={id}

Are these the correct URLs and parameters? I am seeing "RequestId" and "WorkOrderId" URL parameters are duplicated on "SR ID" and "Work Order" URLs respectively.

rssidlowski commented 8 years ago

They are correct URLs. Note the second RequestId does not have the '%3d'.

yousifmalik commented 8 years ago

ok, i will change '=' with '%3d' on both URLs. Please confirm these are good URLs:

https://dpwapps.baltimorecity.gov/Cityworks/Login.aspx?ReturnUrl=%2fCityworks%2fWorkManagement%2fRequestEdit.aspx%3fRequestId%3d218108&RequestId%3d218108

https://dpwapps.baltimorecity.gov/Cityworks/Login.aspx?ReturnUrl=%2fCityworks%2fWorkManagement%2fWoGeneralEdit.aspx%3fWorkOrderId%3d293183&WorkOrderId%3d293183

JMurk commented 8 years ago

Those are correct, but could you update the URL once more from /Cityworks/ to /CityworksTest/ ?

yousifmalik commented 8 years ago

I am seeing two instances of "Cityworks". Can you you provide the exact url using these templates: https://dpwapps.baltimorecity.gov/Cityworks/Login.aspx?ReturnUrl=/Cityworks/WorkManagement/RequestEdit.aspx?RequestId={id}&RequestId={id}

https://dpwapps.baltimorecity.gov/Cityworks/Login.aspx?ReturnUrl=/Cityworks/WorkManagement/WoGeneralEdit.aspx?WorkOrderId={id}&WorkOrderId={id}

yousifmalik commented 8 years ago

Links for SR and work order no longer working on DEV. the code working ok on my local system and when i push to dev the links are not set!

Any changes i should be aware of on dev?

I have these debugging lines: Local DEV system:

targetUrl: https://dpwapps.baltimorecity.gov/Cityworks/Login.aspx?ReturnUrl=/Cityworks/WorkManagement/RequestEdit.aspx?RequestId={id}&RequestId={id}

Generated href: https://dpwapps.baltimorecity.gov/Cityworks/Login.aspx?ReturnUrl=/Cityworks/WorkManagement/RequestEdit.aspx?RequestId=106C000559&RequestId=106C000559

Update html: 106C000559

DEV Server shown empty url: targetUrl: Generated href: Update html: 106C000559

JMurk commented 8 years ago

First- the test URLs should be:

SRs: https://dpwapps.baltimorecity.gov/CityworksTest/WorkManagement/RequestEdit.aspx?RequestId=[id]

WOS: https://dpwapps.baltimorecity.gov/CityworksTest/WorkManagement/WoGeneralEdit.aspx?WorkOrderId=[id]

I'm not sure what you mean by they are not set or not working? I can't even edit the fields in the UX for testing...

yousifmalik commented 8 years ago

Links for SR and WO used to navigate ok to whatever url they were configure with and they are not now!

JMurk commented 8 years ago

I still am not understanding. You can call me if you'd like - 410-316-7800 x1505

yousifmalik commented 8 years ago

OK, problem solved! it was due to the url encoding during the app build for dev environment.

yousifmalik commented 8 years ago

Completed and ready for testing on DEV

slmessier commented 8 years ago

I was able to successfully validate the functionality in the development instance. This issue will be updated to "Ready for Production".