Closed ghost closed 1 year ago
Looks good from a quick look, I'll test it properly later. However one little thing: instead of
switch($var) {
case 1:
// Query 1
case 2:
// Query 2
default:
// Query 2
}
You could do:
switch($var) {
case 1:
// Query 1
case 2:
default:
// Query 2
}
I was also thinking about using getDateFormat
to detect automatically what format should be used (as there are multiple ways to store a date)
Sound great for getDateFormat
, I'll give a try.
Thanks :D I should have time soon to work a bit more with laravel again.
Try was successful, it was deleting after time, even when I overrode getDateFormat
to return another Date Format.
Ok, I'll try to test this tomorrow or the day after.
Any update ?
Sorry, I'm really busy atm - exams, release time for @mybb and some personal things. Don't know when I've more time
Don't know if you'll be updating or maintaining this package anymore, if you would not maintain this package, could I just fork or create a new repository with credits in order to continue to maintain this package (which is helpful)
I plan to maintain the package but it's one of my lower priorities. However feel free to fork the package if you want to ;)
Patch for the issue about Clear() method, please refer to #2
What has been changed ?
datetype
, it has two options :timestamps
- If the user is actually using TRUE timestamps, he has to switch to this thedatetype
date
- If the user is using complete datetime, it's the default option as Laravel isn't using timestamps with Carbon API on the 4.2, 4.1 and neither on the 4.0 but the user can switch to timestamps.