JN-Jones / visitor-log

A package for Laravel 4 to log all visitors
11 stars 8 forks source link

Patch for clear method #3

Closed ghost closed 1 year ago

ghost commented 10 years ago

Patch for the issue about Clear() method, please refer to #2

What has been changed ?

JN-Jones commented 10 years ago

Looks good from a quick look, I'll test it properly later. However one little thing: instead of

switch($var) {
  case 1:
     // Query 1
  case 2:
     // Query 2
  default:
     // Query 2
}

You could do:

switch($var) {
  case 1:
     // Query 1
  case 2:
  default:
     // Query 2
}
JN-Jones commented 10 years ago

I was also thinking about using getDateFormat to detect automatically what format should be used (as there are multiple ways to store a date)

ghost commented 10 years ago

Sound great for getDateFormat, I'll give a try.

JN-Jones commented 10 years ago

Thanks :D I should have time soon to work a bit more with laravel again.

ghost commented 10 years ago

Try was successful, it was deleting after time, even when I overrode getDateFormat to return another Date Format.

JN-Jones commented 10 years ago

Ok, I'll try to test this tomorrow or the day after.

ghost commented 10 years ago

Any update ?

JN-Jones commented 10 years ago

Sorry, I'm really busy atm - exams, release time for @mybb and some personal things. Don't know when I've more time

ghost commented 9 years ago

Don't know if you'll be updating or maintaining this package anymore, if you would not maintain this package, could I just fork or create a new repository with credits in order to continue to maintain this package (which is helpful)

JN-Jones commented 9 years ago

I plan to maintain the package but it's one of my lower priorities. However feel free to fork the package if you want to ;)