JNRowe / hubugs

Simple client for GitHub issues
https://hubugs.readthedocs.io/
GNU General Public License v3.0
6 stars 2 forks source link

hubugs and Vim #28

Closed sorin-ionescu closed 12 years ago

sorin-ionescu commented 12 years ago

When I execute hubugs open, it opens Vim. After I write the title and the description, I save and close Vim.

The issue is not created. hubugs says, No message given.

JNRowe commented 12 years ago

I'm commenting via hubugs and vim now, so I'm not seeing the same problem. A little more information would be useful.

What versions of hubugs and vim are you using?

Does the problem still occur when using vim -U?

Have you recently switched to vim, or have you successfully been using vim and hubugs in the past?

sorin-ionescu commented 12 years ago

Vim and hubugs have never worked for me. I have finally decided to open an issue. I am using the latest hubugs. I am not using the GUI Vim; so, vim -U does not apply.

JNRowe commented 12 years ago

Version numbers would help. Perhaps the problem will be clearly evident if I can replicate your environment a little.

I am not using the GUI Vim; so, vim -U does not apply.

Yeah, my bad. I meant lowercase -u to cover both vim/gvim.

Straw poll on IRC had nine vim users without problems, so there is definitely something odd that need to surface.

sorin-ionescu commented 12 years ago

Perhaps there is something wrong with my vimrc. Maybe, Vim is forking.

JNRowe commented 12 years ago

For what it's worth, you could also use the --stdin option of hubugs and open bugs directly from a vim buffer using :w !hubugs open --stdin. Using a map would make this easier, as would finding the root cause of thie issue ;)

updated: I forgot to add the --stdin option to the command example. Too late to be looking at this now...

sorin-ionescu commented 12 years ago

vim -u won't fix it. hubugs does not seem to use the $EDITOR/$VISUAL variables. I have set them to other editors, and it still opens Vim.

This is my vimrc.

JNRowe commented 12 years ago

hubugs does not seem to use the $EDITOR/$VISUAL variables.

hubugs defers to git config core.editor for editor settings, so anything set there will take precedence.

That said, you need the fix in eeccd453d70c68bfcc02535c202ccaea9f05c431 to use multi-arg editor settings if you wish to use $EDITOR or core.editor that way.

I've asked a few times now for the versions of hubugs and vim you're using, so I can attempt to replicate this locally or at least ask other users to check for me.

sorin-ionescu commented 12 years ago

I don't have core.editor defined.

Vim

VIM - Vi IMproved 7.3 (2010 Aug 15, compiled Mar 5 2012 21:19:11) MacOS X (unix) version Included patches: 1-462

hubugs

1ed968e6fc51

JNRowe commented 12 years ago

I don't have core.editor defined.

Don't know what to say then, works for me:

Ξ Projects/hubugs git:(master) ▶ python -c 'from hubugs.utils import get_editor; print(get_editor())'       
['vim']
Ξ Projects/hubugs git:(master) ▶ EDITOR='vim-server' python -c 'from hubugs.utils import get_editor; print(get_editor())'                                                 
['vim-server']

I use that functionality quite a lot to make use of throwaway scripts as comment and template manglers, and judging by the bugspam I receive others make a lot of similar use of it too.

So, the only remaining thought is the change in feat/mkstemp. If that doesn't work, I'll take another look when I get back to the office but that won't be for a week or two.

JNRowe commented 12 years ago

Did you test the change in feat/mkstemp?

sorin-ionescu commented 12 years ago

I just tested it with hubugs comment 174. It works. I presume that if it works for comment, it should work for all? Thank you.

JNRowe commented 12 years ago

I presume that if it works for comment, it should work for all?

Yes, Should. There is only one code path that pulls an editor up.

Thanks for sticking with me on this, I'm sure its not fun to be on your side of the report fence. Can't promise it will get any better unfortunately, I'm just not able to test on OSX with any regularity.