search

JNRowe / hubugs

Simple client for GitHub issues
https://hubugs.readthedocs.io/
GNU General Public License v3.0
6 stars 2 forks source link

Support multi page results properly #46

Open JNRowe opened 10 years ago

JNRowe commented 10 years ago

Should be handled by parsing the link headers, and following the data they provide.

Seem to be able to get reasonably robust first-effort results from:

r, c = req_get(page)
m = re.findall('<(?P<url>.*?)>; rel="(?P<rel>.*?)"', r['Link'])

Clearly, a proper solution should be saner than that. If/when hubugs comes off the back burner...

JNRowe commented 10 years ago

See 0a983aad2e20ca4effec744b46fb80734686ee0c. Thanks Matt, but even your commit message admits it needs to be better.