JNec / sipservlets

Automatically exported from code.google.com/p/sipservlets
0 stars 0 forks source link

Allow sending retry INVITE after receiving 422 response #143

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1.SIP servlet app sends INVITE to external UAS with small min-SE
2.UAS responds with 422 Session Interval Too Small
3.App sends INVITE again using the existing SipSession

What is the expected output? What do you see instead?
INVITE should be sent, similar to after receiving 401 or 407.
Instead, in MSS 1.7.0-FINAL, an IllegalStateException is thrown - "Cannot
create a subsequent request ... because the dialog is in TERMINATED
state"

What version of the product are you using? On what operating system?
1.7.0-FINAL on Tomcat 6.  Linux

Please provide any additional information below.

Patch to 
sip-servlets-impl/src/main/java/org/mobicents/servlet/sip/core/session/SipSessio
nImpl.java attached.

Original issue reported on code.google.com by eric.sh....@gmail.com on 1 Aug 2012 at 6:18

Attachments:

GoogleCodeExporter commented 8 years ago
Hi Eric, 

Can you sign the Contributor License Agreement at the bottom of 
http://telestax.com/open-source/ ?
Also to acknowledge your contribution to 
http://www.mobicents.org/acknowledgements.html, do you agree to publish your 
company name there ?

Thanks
Jean

Original comment by jean.deruelle on 6 Aug 2012 at 12:22

GoogleCodeExporter commented 8 years ago

Original comment by jean.deruelle on 6 Aug 2012 at 12:23

GoogleCodeExporter commented 8 years ago
Linking to public thread on mobicents-public 
https://groups.google.com/d/topic/mobicents-public/uzPi3ayvPLg/discussion

According to RFC 4028 Session Timer, if a UAC sends INVITE and
receives a 422 Session Interval Too Small response, then it can retry
the INVITE with same Call-ID with a larger min-SE.

Original comment by jean.deruelle on 10 Aug 2012 at 5:31

GoogleCodeExporter commented 8 years ago
This issue was updated by revision 34774e44122a.

Committing Patch + Non Regression Test

Original comment by jean.deruelle on 10 Aug 2012 at 8:03

GoogleCodeExporter commented 8 years ago
This issue was updated by revision f42bd1de59a0.

Backport to TelScale branch

Committing Patch + Non Regression Test
(cherry picked from commit 34774e44122a4b1a36d7c6fb2e22392b8d58b8a6)

Original comment by jean.deruelle on 10 Aug 2012 at 8:03

GoogleCodeExporter commented 8 years ago

Original comment by jean.deruelle on 10 Aug 2012 at 8:04

GoogleCodeExporter commented 8 years ago

Original comment by jean.deruelle on 16 Aug 2012 at 8:10