Heretic and Hexen: upgrade spy mode

JNechaevsky / international-doom

Small, functional and simple source ports, created with help, efforts and bits of code from people around the world.

https://jnechaevsky.github.io/inter-doom/

GNU General Public License v2.0

30 stars 2 forks source link

Heretic and Hexen: upgrade spy mode #112

Closed JNechaevsky closed 9 months ago

JNechaevsky commented 9 months ago

Initially was planned for Hexen only, but other games gets improvements as well:

All games: chosen by F12 player now kept between level changes while multiplayer demo playback. No need to change player over and over again on every level change (probably could be useful for Woof and Crispy, if @fabiangreffrath and @rfomin will be interested?)
Heretic: better toggling, notably automap showing correct player arrow angle on overlay mode.
Hexen: full implementation.
Heretic and Hexen: messages now showing correctly for chosen by F12 player.

TODO for later:

Heretic showing incorrect player arrow color in multiplayer. Will fix after @kitchen-ace's improved secret sectors handling, so we don't have a possible diff issues.

fabiangreffrath commented 9 months ago

Multiplayer spy is one of these obscure features that I can't even remember when I used it the last time. So, I didn't even know that it resets to consoleplayer with each level transition. Sure, I think if you have decided to follow a different player then this decision should hold across levels on multi-level demos.

JNechaevsky commented 9 months ago

Me neither, to be honest. Just noticed that something not right while level changing on Hexen (not even in Doom), I was expecting to check one player's values, but got entirely another player instead. Definitely one of those thing "never know, unless noticed".

JNechaevsky commented 9 months ago

Oh, no, this is wrong approach. Despite of chosen player is kept across levels, this way demo always starts from green (0) player, matters no which player was recording demo itself. Notably on 30uv2245.zip with three players, where every player have own demo file. I'll investigate it farther, probably displayplayer = consoleplayer just needs to be moved to G_DoPlayDemo to be called once without any extra conditions.