search

JNechaevsky / international-doom

Small, functional and simple source ports, created with help, efforts and bits of code from people around the world.
https://jnechaevsky.github.io/inter-doom/
GNU General Public License v2.0
29 stars 2 forks source link

Doom & Heretic: add "Crossfade" screen wiping effect #129

Closed JNechaevsky closed 6 months ago

JNechaevsky commented 6 months ago

Thanks @kitchen-ace for suggestion, as well as @Meerschweinmann and @NightFright2k19 for opinions! Fixes #94.

Not as good implementation as it have to be, but looks pretty decent in compiled-in TrueColor render (always enabled by default). No support for Hexen at this point, it will need extra investigation. Please don't ask anything about "Brain-dead corrections"! 😦

Better do not merge until https://github.com/JNechaevsky/international-doom/pull/128 is merged, I'm afraid we can have some branch conflicts.

Meerschweinmann commented 6 months ago

Hooray, something new to test out 😀 When i am at home tomorrow i will have a look.

kitchen-ace commented 6 months ago

Super smooth!

I wonder if the problems with Hexen are caused by the banners that normally appear between levels? ("Ethereal Travel" etc.) I know they can be shut off in inter-hexen but that's the main difference I can think of between it and the other games. Well, I guess Hexen has no end-of-level tally screen either.

Meerschweinmann commented 6 months ago

Hello, i had a look at the crossfade in Heretic. I like it a lot when it fades smooth from one picture to the next making use of Inter-Heretics truecolor ability. Sure it is not the mega big game-changing feature, but i like it how such features polish the already good Inter-ports even more. Same for text shadows and glowing menu items. Those details show that you love what you do.

Meerschweinmann commented 6 months ago

Hohoho, i have tested the crossfade in Inter-DOOM. I like it much more than the original wipe-effect. Now this is my default in Inter-DOOM too :)

JNechaevsky commented 6 months ago

I wonder if the problems with Hexen are caused by the banners that normally appear between levels? ("Ethereal Travel" etc.)

Honestly, it was my first thought. Looks likes it's not, I even tried to disable banners entirely in the code, but no effect. Presumably, this condition must be additionally somewhere else, I still haven't tried.

I guess Hexen has no end-of-level tally screen either.

It's not a problem to add such transition, I did it Heretic between changing finale text -> finale pic. 🙂

Glad you like it guys! It took really long and painful way since initial implementation from Crispy Strife.