JOJ0 / discodos

A CLI tool for DJ's and record collectors based on the discogs.com collection feature
http://discodos.jojotodos.net/
GNU General Public License v3.0
56 stars 7 forks source link

Disco suggest gives empty results #19

Open kofronpi opened 1 month ago

kofronpi commented 1 month ago

On a clean Ubuntu install from git, after disco import and disco import --tracks && disco import -zz, disco suggest never gives any results.

The matching algorithm seems to be somewhat broken (only 114 tracks from MB, 55 tracks filled with metadata from AB on 304 in my collection), but there is some data :

Processed: 303.
MusicBrainz info added to DiscoBASE: Release MBIDs: 114, Recording MBIDs: 110
AccousticBrainz info added: Key: 55, Chords Key: 55, BPM: 55
No AcousticBrainz entries available yet: 55
Database errors: 0. Not found on Discogs errors: 0. No track number in DiscoBASE errors: 1.
Additional Discogs fetches necessary: 0.

Results of disco suggest:

discodos) pak@***:~/Dev/discodos$ disco suggest -b 123

Showing tracks with a BPM around 123. Pitch range is +/- 6%.

(discodos) pak@***:~/Dev/discodos$ disco suggest -b 120

Showing tracks with a BPM around 120. Pitch range is +/- 6%.

(discodos) pak@***:~/Dev/discodos$ disco suggest -b 130

Showing tracks with a BPM around 130. Pitch range is +/- 6%.

(discodos) pak@***:~/Dev/discodos$ disco suggest -b 100

Showing tracks with a BPM around 100. Pitch range is +/- 6%.

(discodos) pak@***:~/Dev/discodos$ disco suggest -b 140

Showing tracks with a BPM around 140. Pitch range is +/- 6%.

I can't seem to find the debug log file

JOJ0 commented 1 month ago

Several things:

Hope that helps!

If tou want to help me fix the docs, a first step would be to remove or mark as outdated the AcousticBrainz related stuff there!

If you find a bug in the cli, I would prefer not to fix the old cli disco and rather concentrate on dsc. PR's and issues are welcome!

JOJ0 commented 1 month ago

Since you are on Ubuntu and installed from git AFAIR the log file should be somewhere in

~/.discodos/
JOJ0 commented 1 month ago

To spit out debug logs directly on the shell you are executing, use global switches. Eg

dsc -vv suggest -b 123
JOJ0 commented 1 month ago

The matching algorithm seems to be somewhat broken (only 114 tracks from MB, 55 tracks filled with metadata from AB on 304 in my collection), but there is some data :

Yes it probably is! ...and always was....

The matching (which happens before fetching anything from AB) is a very clumsy process that tries to match via artist title catalognumber and tries some variation tricks on cat numbers. It's not very smart though, rather stupid tries different things then gives up. Since data on Discogs and on MB can be very different, if you get 50% of your tracks matched, you are lucky...

The logging is pretty detailed though, try

dsc -vv import -zz
JOJ0 commented 1 month ago

Some of the project's issues I just mentioned are addressed in this PR I'm about to merge: https://github.com/JOJ0/discodos/pull/20

JOJ0 commented 1 month ago

Did any of this help @kofronpi ? Or did you give up on DiscoDOS since you heard the bad news about AcousticBrainz gone for good? ;-)

kofronpi commented 1 month ago

@JOJ0 holidays right now, I will try again later :) But I'm not giving up !