search

JOJ0 / synadm

Command line admin tool for Synapse (the Matrix reference homeserver)
https://synadm.readthedocs.io
GNU General Public License v3.0
183 stars 25 forks source link

User list function breaking change #127

Closed JacksonChen666 closed 1 year ago

JacksonChen666 commented 1 year ago

This was a breaking change for us (using synadm for scripting). The user_list_paginate function uses user_list, but the call of user_list was not updated to include some setting for the admin filter, so calling user_list_paginate inherently fails.

Correct me if I'm wrong, but to me it looks like this may be the problem, so potenially just fixing api.py:471 or extending user_list_paginate's signature with the admin filter would be sufficient. If doing the latter, please consider putting a default value for the admin filter so there's no permanent breaking change for others using the function :)

Thanks for your work on synadm, we highly appreciate it!

Originally posted by @a-0-dev in https://github.com/JOJ0/synadm/issues/123#issuecomment-1719890583

JOJ0 commented 1 year ago

Hi and welcome back @a-0-dev :-) thanks for the detailed report! That helps!