search

JOJ0 / synadm

Command line admin tool for Synapse (the Matrix reference homeserver)
https://synadm.readthedocs.io
GNU General Public License v3.0
186 stars 25 forks source link

Fix GitHub Actions deprecations and warnings #154

Closed JOJ0 closed 1 month ago

JOJ0 commented 1 month ago

Fixes #133

JOJ0 commented 1 month ago

Sorry @JacksonChen666, not really ready for review. Just desperately trying to trigger the release workflow. As I understood it, it should be sufficient to push a tag named v* to trigger it. But it doesn't seem to work...Hmm 🤔

JOJ0 commented 1 month ago

Ok got it, retag.sh helped to remind me on how to trigger/test all this.

Now it's ready to review. Note that in this case the failed release workflow is a good thing. It tells us that the workflow is running as planned triggered via my test-tag-push (v0.46.2) and at least this "early exit" on version mismatch is doing its job correctly:

Screenshot 2024-09-10 at 09 31 15

(Now deleted test tag v0.46.2 again)

As far as I can see all the deprecations as documented in the screenshot in #133 (headline "Annotations") are gone, but please double check!

JOJ0 commented 1 month ago

Thanks for testing! Seems fine!